Fix compiler warnings and a minor bug

[jarkkoka]

• Fix most compiler warnings
• Fix use of deprecated WebSecurityConfigurerAdapter

---

This change is 

[culka]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jarkkoka)

---

spring-boot/src/main/kotlin/fi/hsl/jore4/mapmatching/config/WebSecurityConfig.kt line 23 at r1 (raw file):

            .sessionManagement { it.sessionCreationPolicy(SessionCreationPolicy.NEVER) }
            .csrf { it.disable() }
            .cors {}

CORS was not called in the old configuration. I don't think this empty call does anything.

[jarkkoka]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @culka)

---

spring-boot/src/main/kotlin/fi/hsl/jore4/mapmatching/config/WebSecurityConfig.kt line 23 at r1 (raw file):

Previously, culka (Teemu Mäkinen) wrote…

CORS was not called in the old configuration. I don't think this empty call does anything.

You're right. It does not affect anything. Basically, we are using the default CORS configuration. In other words, CORS is turned on even without this line.

I kind of made the usage of CORS explicit here since it is needed. There is a separate CORS configuration in WebConfig class (under development Spring profile).

Is it ok to leave it here?

[culka]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jarkkoka)

---

spring-boot/src/main/kotlin/fi/hsl/jore4/mapmatching/config/WebSecurityConfig.kt line 23 at r1 (raw file):

Previously, jarkkoka (Jarkko Kaura) wrote…

You're right. It does not affect anything. Basically, we are using the default CORS configuration. In other words, CORS is turned on even without this line.

I kind of made the usage of CORS explicit here since it is needed. There is a separate CORS configuration in WebConfig class (under development Spring profile).

Is it ok to leave it here?

Looks good!