Fix truck travel time matrices and refactor matrix getting #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2022 16:15
zptro
commented
Feb 7, 2022
Comment on lines
+431
to
+432
| if mtx_type == "time" and subtype in param.assignment_modes: | ||
| mtx = self._extract_timecost_from_gcost(subtype) |
There was a problem hiding this comment.
This is the actual bug fix.
johpiip
approved these changes
Feb 8, 2022
johpiip
added a commit
that referenced
this pull request
Feb 18, 2022
* Refactor matrix getting * Refactor further * Change function name Co-authored-by: Jens West <[email protected]>
johpiip
added a commit
that referenced
this pull request
Feb 18, 2022
* Refactor matrix getting * Refactor further * Change function name Co-authored-by: Jens West <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide matrix adjustments in
_get_matricesfunction.