DT-6182 rental scooters #5016
Merged
DT-6182 rental scooters #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename for consistency - scooters can use exactly similar state as other itinerary queries
…ately This prevents intermediate rendering before plan merging
UI contained lots of complex code for adding citybike and scooter to transport modes array. In the end, those were just filtered away before making a request. Most of the old mess is now cleaned away. There is still some strange code related to availableForSelection config switch; it should probably be erased as well.
It does nothing.
We could add ? to every object reference but would it make the code better?
Wheelchair option disables biking and scooters. Do the same with citybikes.
The button in scooter leg says 'Open settings'. Toggle will actually close the panel if it is already open.
vesameskanen
approved these changes
Jun 28, 2024
|
I added some minor fixes and refactored the code. There might be still a need for renaming more citybike things to a generic form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When testing
Relies on:
HSLdevcom/OpenTripPlanner-data-container#403
opentripplanner/OpenTripPlanner#5909
Pull Request Check List
Review