fix: dev: Change static path to shared_dir attribute #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,7 +103,8 @@ def create_interfaces(): | |||
| raise Exception('Failed to map ports with port labels') | |||
|
|
|||
| # Writting mapping to file | |||
| with open('/tmp/port_mapping.json', 'w') as json_file: | |||
| shared_dir_tmp = str(__file__).split('openswitch_setup.py')[0] | |||
There was a problem hiding this comment.
If you believe there's a better way to get this path, please let me know
There was a problem hiding this comment.
Please use os.path functionality.
| .format(logs_path, | ||
| node_obj.shared_dir_mount), | ||
| shell='bash') | ||
| path_name = '/tmp/{}_{}'.format(item.name, str(id(item))) |
There was a problem hiding this comment.
What if there are 2 test cases with the same name in 2 different test suites?
There was a problem hiding this comment.
Added test suite name as requested to folder name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some static paths were left behind and plugin to move openswitch container logs to test name folder