264 freshness sli value denominator using wrong function (#265)

* bug: Changed Sum by to count by * bug: also changed sum to count in prometheus for consistency
HO-CTO · Sep 30, 2022 · b1df9e5 · b1df9e5
1 parent a56a05a
commit b1df9e5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/monitoring-as-code/src/sli-value-libraries/average-freshness-using-queue-metric.libsonnet b/monitoring-as-code/src/sli-value-libraries/average-freshness-using-queue-metric.libsonnet
@@ -37,7 +37,7 @@ local createSliValueRule(sliSpec, sliMetadata, config) =
           (
             sum by(%(selectorLabels)s) (avg_over_time((%(oldestMessageMetric)s{%(selectors)s, %(queueSelector)s} > bool %(latencyTarget)s)[%(evalInterval)s:%(evalInterval)s]))
             /
-            sum by(%(selectorLabels)s) (count_over_time(%(oldestMessageMetric)s{%(selectors)s, %(queueSelector)s}[%(evalInterval)s]))
+            count by(%(selectorLabels)s) (count_over_time(%(oldestMessageMetric)s{%(selectors)s, %(queueSelector)s}[%(evalInterval)s]))
           ),
         "sli_environment", "$1", "%(environmentSelectorLabel)s", "(.*)"), "sli_product", "$1", "%(productSelectorLabel)s", "(.*)"))
       ||| % {
@@ -91,7 +91,7 @@ local createGraphPanel(sliSpec) =
       |||
         sum(avg_over_time((%(oldestMessageMetric)s{%(selectors)s, %(queueSelector)s} > bool %(latencyTarget)s)[%(evalInterval)s:%(evalInterval)s]) or vector(0))
         /
-        sum(count_over_time(%(oldestMessageMetric)s{%(selectors)s, %(queueSelector)s}[%(evalInterval)s]))
+        count(count_over_time(%(oldestMessageMetric)s{%(selectors)s, %(queueSelector)s}[%(evalInterval)s]))
       ||| % {
         oldestMessageMetric: targetMetrics.oldestMessage,
         queueSelector: '%s!~"%s"' % [metricConfig.customSelectorLabels.deadletterQueueName, metricConfig.customSelectors.deadletterQueueName],