Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

更改主页 UI #3129

Merged
merged 6 commits into from
Oct 26, 2024
Merged

更改主页 UI #3129

merged 6 commits into from
Oct 26, 2024

Conversation

burningtnt
Copy link
Member

image

3gf8jv4dv
3gf8jv4dv reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1e68198 (#3129), burningtnt/HMCL/actions/runs/9534351876

The current UI design does not mesh well with the English strings changed by this PR. When the user is in English, the last word of Game Instance Settings is blocked. I cannot find a way to make the left sidebar wider.

Preview

@burningtnt
Copy link
Member Author

How about changing 'Game Instance Settings' to a shorter phrase?

@3gf8jv4dv
Copy link
Contributor

How about changing 'Game Instance Settings' to a shorter phrase?

Sure.

@burningtnt
Copy link
Member Author

Sure.

Can you provide any suggestion? I'm not a native Enligsh spaker.

@3gf8jv4dv
Copy link
Contributor

Can you provide any suggestion? I'm not a native Enligsh spaker.

Instance Settings is all it takes. Prism Launcher also adopts this description.

@burningtnt
Copy link
Member Author

image
Nice. Thank you

@3gf8jv4dv
Copy link
Contributor

The current UI design does not mesh well with the English strings changed by this PR. When the user is in English, the last word of Game Instance Settings is blocked. I cannot find a way to make the left sidebar wider.

Off topic. It occurred to me that there are similar issues in several other places in the launcher, but those issues are different from this PR and can basically be solved by modifying the i18n files. Should I create a PR to fix the above issues?

@burningtnt
Copy link
Member Author

burningtnt commented Jun 26, 2024 •
edited
Loading

The current UI design does not mesh well with the English strings changed by this PR. When the user is in English, the last word of Game Instance Settings is blocked. I cannot find a way to make the left sidebar wider.

Off topic. It occurred to me that there are similar issues in several other places in the launcher, but those issues are different from this PR and can basically be solved by modifying the i18n files. Should I create a PR to fix the above issues?

You are always welcomed to contribute. Thanks!

@3gf8jv4dv 3gf8jv4dv mentioned this pull request Jun 26, 2024
Closed
@burningtnt burningtnt mentioned this pull request Jul 13, 2024
Closed
3gf8jv4dv added a commit to 3gf8jv4dv/HMCL that referenced this pull request Sep 10, 2024
@3gf8jv4dv
Revise 8
a27cb88 
Various revisions for:
- English (United States)
- Chinese (Simplified, Mainland China)

Several translations port from HMCL-dev#3129.
@3gf8jv4dv
Copy link
Contributor

@Glavo What do you think? I think it is a good change, it matches the launch button in the bottom right corner of the home page, and it lets users know exactly what this button does.

Note that the i18n parts in this PR are outdated — I replaced them with new translations in some recent PRs.

@Glavo
Merge branch 'main' into feature/change-root-page-ui
e15986c 
# Conflicts:
#	HMCL/src/main/resources/assets/lang/I18N.properties
#	HMCL/src/main/resources/assets/lang/I18N_zh.properties
#	HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties
@Glavo
update
e528bc6
@Glavo Glavo merged commit 959adf1 into HMCL-dev:main Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv requested changes

@Glavo Glavo Glavo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burningtnt @3gf8jv4dv @Glavo