Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2796 #2804

Merged
merged 27 commits into from
Mar 10, 2024
Merged

fix #2796 #2804

merged 27 commits into from
Mar 10, 2024

Conversation

zkitefly
Copy link
Member

@zkitefly zkitefly commented Feb 14, 2024

fix #2796

image

image

image

@zkitefly zkitefly requested review from burningtnt, huanghongxun and Glavo and removed request for huanghongxun February 14, 2024 06:00
@zkitefly zkitefly marked this pull request as draft February 14, 2024 06:16
@zkitefly zkitefly marked this pull request as ready for review February 14, 2024 07:19
@burningtnt
Copy link
Member

日志窗口不需要显示这些信息,因为 hmcl.log 中已经有了

@zkitefly
Copy link
Member Author

日志窗口不需要显示这些信息,因为 hmcl.log 中已经有了

有些人会在 日志 窗口导出日志,想添加更多信息方便排查问题(而且加了又没事)

@zkitefly zkitefly requested a review from hejiehao February 15, 2024 01:05
@burningtnt
Copy link
Member

请手动做 URL 格式化,避免用户浏览器及字符集问题

@burningtnt
Copy link
Member

并且,我反对往日志面板里写这些信息 —— 他们已经被展示在了崩溃信息提示界面,不需要重复展示

@hejiehao
Copy link
Contributor

爆了()

@zkitefly
Copy link
Member Author

爆了()

你真领灵敏(

@Glavo Glavo merged commit 389b931 into HMCL-dev:main Mar 10, 2024
3 checks passed
Comment on lines -453 to -460
game.crash.reason.mod_resolution_collection=当前游戏因为前置模组版本不匹配,无法继续运行。\n%1$s 需要前置模组:%2$s 才能继续运行。\n这表示你需要更新或降级前置。你可以到下载页的模组下载,或到网上下载 %3$s。
game.crash.reason.mod_resolution_conflict=当前游戏因为模组冲突,无法继续运行。\n%1$s 与 %2$s 不能兼容。
game.crash.reason.mod_resolution_missing=当前游戏因为缺少模组前置,无法继续运行。\n%1$s 需要前置模组:%2$s 才能继续运行。\n这表示你少安装了模组,或该模组版本不够。你可以到下载页的模组下载,或到网上下载 %3$s。
game.crash.reason.mod_resolution_missing_minecraft=当前游戏因为模组和 Minecraft 游戏版本不匹配,无法继续运行。\n%1$s 需要 Minecraft %2$s 才能运行。\n如果你要继续使用你已经安装的模组,你可以选择安装对应的 Minecraft 版本;如果你要继续使用当前 Minecraft 版本,你需要安装对应版本的模组。
game.crash.reason.mod_resolution_mod_version=%1$s (版本号 %2$s)
game.crash.reason.mod_resolution_mod_version.any=%1$s (任意版本)
game.crash.reason.forge_repeat_installation=当前游戏因为 Forge 重复安装,无法继续运行。<a href="https://github.com/HMCL-dev/HMCL/issues/1880">此为已知问题</a>\n建议将日志上传反馈至 GitHub ,以便我们找到更多线索并修复此问题。\n目前你可以到 自动安装 里头卸载 Forge 并重新安装。
game.crash.reason.optifine_repeat_installation=当前游戏因为 OptiFine 重复安装,无法继续运行。\n请删除 Mod 文件夹下的 OptiFine 或前往 游戏管理-自动安装 卸载自动安装的 OptiFine。
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?为什么要删掉

Copy link
Member

@Glavo Glavo Mar 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些是重复的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] HMCL 游戏崩溃窗口的崩溃原因分析显示出错
4 participants