Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

前置模组无法打开链接 #2104

Closed
hexadecimal233 opened this issue Feb 11, 2023 · 7 comments · Fixed by #2411
Closed

前置模组无法打开链接 #2104

hexadecimal233 opened this issue Feb 11, 2023 · 7 comments · Fixed by #2411
Labels
bug

Comments

@hexadecimal233
Copy link

启动器版本 Launcher Version

3.5.dev-54eab87

平台 Platform

Windows 11

问题描述 Problem Description

前置模组的链接打不开，正常模组链接打得开

Java

No response

游戏版本 Game Version

No response

对游戏所做的修改 Modifications Made to the Game

No response

游戏崩溃报告 Game Crash Report

No response

启动器崩溃报告 Launcher Crash Report

No response

启动器日志文件 Launcher Log File

No response
@zkitefly
Copy link
Member

能否提供下是那个 Mod 页面这样呢

@hexadecimal233
Copy link
Author

Modrinth->Iris->Sodium

@zkitefly
Copy link
Member

我试了下，的确复现了

@Glavo
Copy link
Member

Glavo commented Feb 19, 2023

复现不出来。哪个链接打不开？

@burningtnt
Copy link
Member

我试了下，的确复现了

详细描述一下？

@zkitefly
Copy link
Member

zkitefly commented Jul 30, 2023 •
edited
Loading

_._20230730115551.mp4

hmcl-exported-logs-2023-07-30T11-56-36.log

@burningtnt
Copy link
Member

Bug 原因：org.jackhuang.hmcl.mod.modrinth.ModrinthRemoteModRepository.Project#toMod 里给 pageURL 传了个 null 进去

burningtnt added a commit to burningtnt/HMCL that referenced this issue Jul 30, 2023
@burningtnt
Fix HMCL-dev#2104
ab64be9
@burningtnt burningtnt mentioned this issue Jul 30, 2023
Merged
huanghongxun pushed a commit that referenced this issue Jan 8, 2024
@burningtnt
Support Neoforge (#2548)
4149876 
* Support #2376

* Add necessary @nullable annotations

* Display different types of dependencies in different sections.

* Fix checkstyle

* Add I18N for different types of dependencies.

* Enhance UI

* Code cleanup

* Enhance UI

* Manually sort the result from curseforge when searching mods by name.

* Render the search results from remote mod repositories in several pages.

* Fix merge

* Fix

* Add a button which navigates to the modpack download page in the modpack installl page

* Fix I18N

* Render the mod loaders supported by the version in mod info page.

* Fix #2104

* Enhance TwoLineListItem

* Render the mod loader supported by this mod file on the ModListPage

* Fix chinese searching and curseforge searching

* Update I18N

* Fix

* Fix

* Select the specific game version when clicking the 'download' button on ModListPage

* Support HMCL to update mod_data and mod_pack data from https://github.com/huanghongxun/HMCL/raw/javafx/data-json/dynamic-remote-resources.json

* Enhance :HMCL:build.gradle.kts

* Revert parse_mcmod_data.py

* Abstract 'new Image' to FXUtils.newBuiltinImage and FXUtils.newRemoteImage

FXUtils.newBuiltinImage is used to load image which is supposed to be correct definitely and is a file within the jar. Or, it will throw ResourceNotFoundError.

FXUtils.newRemoteImage is used to load image from the internet. It will cache the data of images for the further usage. The cached data will be deleted when HMCL is closed or hidden.

* Add javadoc for FXUtils.newBuiltinImage and FXUtils.newRemoteImage.

* Fix checkstyle

* Fix

* Fix

* Fix

* Add license for RemoteResourceManager

* Remove TODO

* Enhance Chinese searching

* Support to decode metadata for local quilt mod.

* Enhance ModManager

* Fix checkstyle

* Refactor

* Fix

* Fix

* Refactor DownloadPage

* Fix

* Revert "Refactor DownloadPage"

This reverts commit 953558d.

* Refactor DownloadPage

* Refactor

* Fix

* Fix checkstyle

* Set org.jackhuang.hmcl.ui.construct.TwoLineListItem.TagChangeListener as a private static inner class.

* Fix

* Fix

* Fix

* Enhance SimpleMultimap

* Revert TwoLineListItem

* Fix

* Code cleanup

* Code cleanup

* Fix

* Code cleanup

* Add license for IModMetadataReader

* Add prefix 'Minecraft' at the supported minecrft version list in DownloadPage

* Fix #2498

* Update README_cn.md

* Opti ModMananger

* Log a warning message when 'hmcl.update_source.override' is used.

* Fix chinese searching

* Enhance chinese searching.

* Enhance memory usage

* Add basic support for NeoForge.

* Enable HMCl to show the version list of NeoForged.

* Fix checkstyle

* Enable HMCL to download and install NeoForged from BMCL. Fix some bugs.

* Close the mod version dialog window after clicking the downloading / save as button if the dependency list is empty.

* Fix

* Enable HMCL to install NeoForge from modpacks.

* Fix the dirty implememtation

* Fix UI

* Cache builtin images.

* Enhance FXUtils (Make tooltip installer faster).

* Fix

* Fix

* Fix #2560

* Fix typo

* Fix remote image cache.

* Fix javadoc

* Fix checkstyle

* Optimize FXUtils::shutdown

* Support NeoForged 1.20.2

* Fix merge

* I have no idea on why the sha1 was matched.

* Revert "Enhance FXUtils (Make tooltip installer faster)."

This reverts commit 0a49eb2.

* Support multi download source in order balance the traffic of hmcl.huangyuhui.net and the download speed in China Mainland.

* Modify dynamic remote resource urls.

* Optimize codes with StringUtils.DynamicCommonSubsequence.

* Prevent unofficial HMCL to access HMCL Resource Update URL.

* Zip the dynamic-remote-resources json by Gradle automatically.

* Remove unnecessary getters.

* Fix

* Fix LibraryAnalyzer: Cannot analyze the version number of NeoForge correctly.

* Support to choose the NeoForge icon if a game is installed with NeoForge.

* Fix checkstyle

* Fix: The version number on DownloadPage of NeoForge is incorrect, which has leading string 'neoforge-'.

* Fix.

* Rename references. Fix: Invalid spaces in VersionIconType.

---------

Co-authored-by: Burning_TNT <[email protected]“>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance mod download burningtnt/HMCL
4 participants
@Glavo @hexadecimal233 @zkitefly @burningtnt