Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
ビジネスロジックとしてのフィボナッチ数の計算とテストを実装。実装の際にはメモ化を用いた。
今回の変更範囲はビジネスロジックのみであり,それを実際にLambdaから呼び出す部分は未実装。
変更内容
大きな整数に対応できるよう
bigint
で計算し返却するようにした。n=1~17あたりの小さな数と,n=50,100,1000などの大きな数でテスト。なお,テストをjestで動かす際に
bigint
に関わるエラーが発生したので,jest.config.tsに"workerThreads": true"を追記した。(参考リンク)テスト
実装したfibonacci関数のテストを行った。
先述の通りLambdaからの呼出は未実装なので,APIのテストは行っていない。
関連Issue
#3