New sign up page with form completed and major and year dropdown done. #75
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import * as React from 'react'; | ||
| import { MenuItem, TextField } from '@material-ui/core'; | ||
| import { getIn } from 'formik'; | ||
|
|
||
| import ELIGIBLE_MAJORS from '../../../constants/eligibleMajors'; | ||
|
|
||
| const createFullMajorTitle = (department, major) => { | ||
| let fullMajorTitle = ''; | ||
|
|
||
| if (ELIGIBLE_MAJORS[department][major] === 'Computer Engineering') { | ||
| if (department === 'CSE') | ||
| fullMajorTitle = `${ELIGIBLE_MAJORS[department][major]} - CSE`; | ||
| else if (department === 'ECE') | ||
| fullMajorTitle = `${ELIGIBLE_MAJORS[department][major]} - ECE`; | ||
| } else fullMajorTitle = ELIGIBLE_MAJORS[department][major]; | ||
|
|
||
| return fullMajorTitle; | ||
| }; | ||
|
|
||
| /* | ||
| * From https://github.com/stackworx/formik-material-ui/tree/master/packages/formik-material-ui/src (TextField) :p | ||
| * This essentially takes the props received at the top-level <Field /> as well | ||
| * as the default props for that <Field /> (field, form, meta) and transforms | ||
| * all that into a props that is suitable for MUI's <TextField /> | ||
| */ | ||
| export function fieldToTextField({ | ||
| disabled, | ||
| field, | ||
| form: { isSubmitting, touched, errors }, | ||
| ...props | ||
| }) { | ||
| const fieldError = getIn(errors, field.name); | ||
| const showError = getIn(touched, field.name) && !!fieldError; | ||
|
|
||
| return { | ||
| ...props, | ||
| ...field, | ||
| error: showError, | ||
| helperText: showError ? fieldError : props.helperText, | ||
| disabled: disabled ?? isSubmitting, | ||
| variant: props.variant, | ||
| }; | ||
| } | ||
|
|
||
| const MajorDropdown = props => { | ||
| return ( | ||
| <TextField select {...fieldToTextField(props)}> | ||
| {Object.keys(ELIGIBLE_MAJORS).map(department => | ||
| Object.keys(ELIGIBLE_MAJORS[department]).map(major => { | ||
| const fullMajorTitle = createFullMajorTitle(department, major); | ||
| return <MenuItem value={fullMajorTitle}>{fullMajorTitle}</MenuItem>; | ||
| }) | ||
| )} | ||
| </TextField> | ||
| ); | ||
| }; | ||
|
|
||
| export default MajorDropdown; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import * as React from 'react'; | ||
| import { MenuItem, TextField } from '@material-ui/core'; | ||
| import { getIn } from 'formik'; | ||
|
|
||
| const yearDropdownChoices = (minYear, maxYear) => { | ||
| const yearChoices = []; | ||
|
|
||
| for (let year = 0; year <= maxYear - minYear; year += 1) { | ||
| yearChoices.push(year + minYear); | ||
| } | ||
|
|
||
| return yearChoices; | ||
| }; | ||
|
|
||
| /* | ||
| * From https://github.com/stackworx/formik-material-ui/tree/master/packages/formik-material-ui/src (TextField) :p | ||
| * This essentially takes the props received at the top-level <Field /> as well | ||
| * as the default props for that <Field /> (field, form, meta) and transforms | ||
| * all that into a props that is suitable for MUI's <TextField /> | ||
| */ | ||
| export function fieldToTextField({ | ||
| disabled, | ||
| field, | ||
| form: { isSubmitting, touched, errors }, | ||
| ...props | ||
| }) { | ||
| const fieldError = getIn(errors, field.name); | ||
|
There was a problem hiding this comment. This is probably the only thing I found that actually explains what getIn() does lol. I don't know why there is no documentation for it on Formik's official website, even though getIn() is imported from formik. |
||
| const showError = getIn(touched, field.name) && !!fieldError; | ||
|
There was a problem hiding this comment. no bang bang hacks :) just check if it's null or sth idk what getIn returns |
||
|
|
||
| return { | ||
| ...props, | ||
| ...field, | ||
| error: showError, | ||
| helperText: showError ? fieldError : props.helperText, | ||
| disabled: disabled ?? isSubmitting, | ||
|
There was a problem hiding this comment. again change to null check for future sustainability - not a big fan of ?? There was a problem hiding this comment. Honestly that stuff is the stuff that came from formik-material-ui that I didn't touch. I'll change it tho |
||
| variant: props.variant, | ||
| }; | ||
| } | ||
|
|
||
| const YearDropdown = props => { | ||
| const { minyear, maxyear } = fieldToTextField(props); | ||
|
|
||
| return ( | ||
| <TextField select {...fieldToTextField(props)}> | ||
| {yearDropdownChoices(minyear, maxyear).map(year => ( | ||
| <MenuItem key={year} value={year}> | ||
| {year} | ||
| </MenuItem> | ||
| ))} | ||
| </TextField> | ||
| ); | ||
| }; | ||
|
|
||
| export default YearDropdown; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this file changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing indentation? Not sure why this was changed, it might have been done by VSCode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay yeah it's indentation changes made automatically by VSCode, the actual code is still the same as the original html file.