114 house system page #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kn-portal into 114-house-system-page
…kn-portal into 114-house-system-page
niannianwang
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
- no functionality problems in the house graphs (select and unselect works good, inductees don't see the page)
- one little thing is that i would expect when i select a point on the graph (or select a specific house on the bar chart), the description for that point will stay on display until you unselect
- will have to wait and see the resize when we have more and more events
- i didn't know that there are that much you can work with google sheets in extracting information😮👍
ryanyychen
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created House page which shows updated leaderboard of house points.