Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defensive driving PR #61

Open
dfridovi opened this issue Sep 1, 2021 · 1 comment
Open

Defensive driving PR #61

dfridovi opened this issue Sep 1, 2021 · 1 comment
Assignees
@chihyuanchiu

Comments

@dfridovi
Copy link
Member

dfridovi commented Sep 1, 2021

@chihyuanchiu can you clean up and open a PR to merge the defensive driving branch into master? I thought it was already in there but evidently it's not...
@dfridovi
Copy link
Member Author

dfridovi commented Sep 8, 2021 •
edited
Loading

@chihyuanchiu your latest commit seems to have broken a ton of the examples. Try running skeleton_example now and it totally breaks.. I have to revert to 4ec2ea7 to get it to even run past the first commit (needs an --initial_alpha_scaling=0.3 modification even there to run correctly). I reverted your previous merge (5bff5dd). Before making any changes to master, please open a PR from your branch to master and confirm that all examples still run reasonably well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chihyuanchiu chihyuanchiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfridovi @chihyuanchiu