Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some Unit test to IOServer #46

Closed
wants to merge 2 commits into from

Conversation

KingExtree
Copy link

add some Unit test to IOServer and ColorSetting

Copy link
Contributor

@FerdinandSu FerdinandSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the codes LGTM, but a few changes are required before merging:

  1. Obsoleted Jvav version -- 1.6
  2. Chinese Comments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unbelievable to use Jvav 1.6 in 2024. as described in POM.xml, JMobileSuit uses Jvav 21.

public void testSelectColorWithDefault() {
ColorSetting colorSetting = new ColorSetting();

// 测试当 customColor 为 null 时返回默认颜色
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use English for I18n

@FerdinandSu FerdinandSu closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants