Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 789] Newsletter Pages #804

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

andycochran
Copy link
Collaborator

Summary

Fixes #789

Time to review: 20 mins

Changes proposed

  • Add pages
    • /newsletter
    • /newsletter-confirmation
    • /newsletter-unsubscribe
  • Stub in the Sendy HTML form

Context for reviewers

Additional information

image

image

image

@andycochran
Copy link
Collaborator Author

Now that Sammy's PR for the homepage is in, I realize this coulda been a lot cleaner. Prob should make that disclaimer a component. We also might put the alert in its own component so we don't have to repeat the content

Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Great start.

@andycochran andycochran merged commit 2f948fc into main Dec 6, 2023
8 checks passed
@andycochran andycochran deleted the andycochran/789--newsletter-routes-pages branch December 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add new routes and pages for newsletter sign-up pages
2 participants