[Issue 704] Breadcrumbs #776
Conversation
SammySteiner
requested review from
andycochran,
acouch,
aplybeah and
chouinar
There was a problem hiding this comment.
Could we infer hierarchy from routes so we don't have to define the breadcrumb trail for each page? Might there be downsides for doing that? We'd still need a lookup for the title strings. 🤔 Just thinking out loud here. No change required, maybe just food for thought as we get into more complex info architecture and page/route structures.
There was a problem hiding this comment.
I thought about that too and was considering using https://nextjs.org/docs/app/api-reference/functions/use-pathname to get and and then break up the path. But realized as you mentioned we'd still need to look up the title strings based on the path, so doesn't really save us much and can be harder to track down if it breaks.
| }; | ||
| export default meta; | ||
|
|
||
| export const Home = { |
There was a problem hiding this comment.
I don't think we'd ever show breadcrumbs on root. Okay to show how it'd work if we did tho.
There was a problem hiding this comment.
Yeah, I wasn't sure what to use for the default story. I could change it to be either Research or Process 🤷, let me know if you have a preference
There was a problem hiding this comment.
Probably fine as-is. We can revisit in the future as our route/page requirements become more complex.
Summary
Fixes #704
Time to review: 10 mins
Changes proposed
Added breadcrumb component, constants, types, story, and test. Added component to process and research page.
Additional information
Process:
Research:
Story:
