[ISSUE 597] Fix health check for frontend container #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E" that is always overriding our config...
daphnegold
requested review from
andycochran,
acouch and
SammySteiner
as code owners
acouch
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #597
Time to review: 5 mins
Changes proposed
Set hostname conditionally Terraform for frontend only, setting it in api is breaking. I think the issue is multifold... a breaking change to the way they handle hostname in next.js + AWS Fargate already having a default environment variable named HOSTNAME that overrides ours unless we explicitly set it (overriden in Dockerfile or whatever). Regardless, setting hostname to "0.0.0.0" fixes it. Tried upgrading to 13.5.5 but that didn't work.
Additional information
vercel/next.js#54133
https://github.com/vercel/next.js/pull/53131/files#diff-3a7de5f9ca3729cdc0a041e9d4c22391754e702ba49ba230daf55730bdc70d99R1975
vercel/next.js#54445
https://github.com/vercel/next.js/blob/canary/packages/next/src/build/utils.ts