Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Issue 591 healthcheck (#592)" #598

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Revert "[Issue 591 healthcheck (#592)" #598

merged 1 commit into from
Oct 16, 2023

Conversation

acouch
Copy link
Collaborator

@acouch acouch commented Oct 16, 2023

This reverts commit 8bb0c92.

Summary

Relates to #591

Time to review: 10 mins

Changes proposed

Rolls back changes for health check.

daphnegold
daphnegold approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@daphnegold daphnegold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good idea, but it didn't work, unfortunately. We can pull in the docker-compose health check stuff later if we want. It's kinda neat to have a health check running locally.

@daphnegold daphnegold merged commit 1788399 into main Oct 16, 2023
@daphnegold daphnegold deleted the revert-592-sammysteiner/issue-591-healthcheck branch October 16, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphnegold daphnegold daphnegold approved these changes

@andycochran andycochran Awaiting requested review from andycochran andycochran is a code owner

@SammySteiner SammySteiner Awaiting requested review from SammySteiner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acouch @daphnegold