Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 514] Remove NOFO content from static site milestone #539

Merged

Conversation

widal001
Copy link
Collaborator

Summary

Updates milestone docs to remove NOFO content and target release date attribute

Fixes #514

Time to review: 3 mins

Changes proposed

What was added, updated, or removed in this PR.

  • Removes references to NOFO transformation workstream from milestone doc
  • Removes "target release date" row from milestone doc metadata
  • Updates template to include metadata that is consistent across milestone docs

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

It may be easier to view the rendered versions of the docs to review

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

Since content about the NOFO workstream has been descoped from the static
site launch, we are removing NOFO references from the milestone doc
Removes target date row and updates link to roadmap
@widal001 widal001 requested review from lucasmbrown-usds, andycochran, acouch and sumiat and removed request for lucasmbrown-usds September 25, 2023 14:47
- Open source repository
- Open source wiki
- Open source chat
10. Stretch: Number of form responses
9. Stretch: Number of form responses
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not asking for a change here but wanted to note a PROTIP:

To create an ordered list, add line items with numbers followed by periods. The numbers don’t have to be in numerical order, but the list should start with the number one.

So you can do this:

1. First item
1. Second item
1. Third item
1. Fourth item

…and it'll render like this:

  1. First item
  2. Second item
  3. Third item
  4. Fourth item

…then you don't have to worry about setting the right number.

Aside: This reminds me of an article I just read about "a single HTML tag (ordered lists) and end with the downfall of civilization."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose all 1s is less helpful when viewing a document as code (not rendered markdown).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andycochran This is a good tip to limit unnecessary diffs!

Currently I use Markdown All in One as my VSCode extension for formatting Markdown, which automates the process of updating numbers in ordered lists, so (fortunately) I'm not manually reordering these myself. Still it is a pain to see the diffs on lines that didn't actually result in content changes.

I'll have to check if that VSCode extension supports configuring ordered lists to only use 1. like you mentioned. Do you use a different markdown extension for VSCode?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also that article is a wild ride, but I love it!! I could feel the computational law recesses of my brain itching as I was reading it 😅

Copy link
Collaborator

@andycochran andycochran Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh! I'll check out the Markdown All in One extension. I'm new to VS Code, was an Atom (R.I.P.) user until this project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same!! Atom was so great, I'm still salty they sunsetted it. And Atom did have a great Markdown plugin that followed the 1. only style for ordered lists

@widal001 widal001 merged commit adafa6c into main Sep 28, 2023
@widal001 widal001 deleted the issue-514-remove-nofo-content-from-static-site-milestone branch September 28, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove NOFO references from Static Site milestone doc
2 participants