Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 285] Reconfigure Github Actions CI/CD for mono-repo structure #511

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

daphnegold
Copy link
Contributor

@daphnegold daphnegold commented Sep 14, 2023

Summary

Fixes #285

Time to review: 10 mins

Changes proposed

  • Remove script to verify checks that run simultaneously
  • Remove deploy workflow triggers on changes to /bin and /infra because they aren't necessary
  • Remake workflows into a pipeline pattern where certain checks run pre-deploy
  • Checks still run on pull request, but not on "push" to main. Instead that is managed by workflow call and our CD pipeline

Context for reviewers

The idea is that we can rework deployment pipelines so they are more visually appealing and simple to understand. Will continue to iterate on this. We are waiting only on the checks we care about to deploy the frontend or backend, namely vulnerability scans and the various test & build suites associated with each app.

Successful frontend pipeline
Successful API pipeline

You can test the pipelines by using workflow dispatches.

Additional information

Frontend Pipeline Stages
Screenshot 2023-09-14 at 12 36 45 PM
Screenshot 2023-09-14 at 12 39 59 PM
8-83c7-f584bd1e7a59">
Screenshot 2023-09-14 at 12 24 47 PM

API Pipeline Stages
Screenshot 2023-09-14 at 12 50 17 PM
Screenshot 2023-09-14 at 12 55 40 PM
Screenshot 2023-09-14 at 1 02 31 PM

@daphnegold daphnegold marked this pull request as ready for review September 14, 2023 19:30
Copy link
Contributor

@SammySteiner SammySteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So excited for this change!

@SammySteiner SammySteiner merged commit 0964452 into main Sep 15, 2023
@SammySteiner SammySteiner deleted the daphnegold/fix-monorepo-checks branch September 15, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Reconfigure Github Actions CI/CD for mono-repo structure
2 participants