Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 397] SEO title and description #418

Merged
merged 10 commits into from
Aug 25, 2023

Conversation

SammySteiner
Copy link
Contributor

@SammySteiner SammySteiner commented Aug 24, 2023

Summary

Fixes #397

Time to review: 5 minutes

Changes proposed

  • Added Head to index page with title and meta description
  • Added content for title and meta description to i18n

Context for reviewers

I took a guess at the content, so that'd be the most important piece to review. But changing/updating that in the future would be a 1 point ticket, so it's really not a big deal to update.

Additional information

Title in tab

image

Google lighthouse score

image

@SammySteiner SammySteiner changed the title title and head in index [Issue 397] SEO title and description Aug 24, 2023
@SammySteiner SammySteiner marked this pull request as ready for review August 24, 2023 19:48
@SammySteiner SammySteiner requested a review from acouch August 24, 2023 19:49
"intro": "This is a template for a React web application using the <LinkToNextJs>Next.js framework</LinkToNextJs>.",
"body": "This is template includes:<ul><li>Framework for server-side rendered, static, or hybrid React applications</li><li>TypeScript and React testing tools</li><li>U.S. Web Design System for themeable styling and a set of common components</li><li>Type checking, linting, and code formatting tools</li><li>Storybook for a frontend workshop environment</li></ul>",
"page_title": "Home | Beta.grants.gov",
"meta_description": "The beta version of a government website where federal agencies post discretionary funding opportunities and grantees find and apply for them",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Let's use some already-approved copy.

Maybe repeat the phrase from goal_paragraph_2: "A one-stop shop for all federal discretionary funding to make it easy for you to discover, understand, and apply for opportunities."

Or the last sentence in goal_paragraph_1: "Our mission is to increase access to grants and improve the grants experience for everyone."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumiat / @itsemilyianacone, do y'all have thoughts on which of these are better from a product perspective? I think I like the first one, but the 2nd is shorter. Minimal edits to approved content can make an even snappier description phrase: "Making it easy for you to discover, understand, and apply for opportunities."

Note: I'm not a big fan of the unnecessary "one-stop-shop" idiom. It's best to "prefer the concrete word to the abstraction" (per plainlanguage.gov). We might also consider changing that in goal_paragraph_2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I have to pick, I'd go with the first. The first description is more clear/specific about what the beta site offers. The second is more around the broader mission and goal. For SEO reasons, I'd go with the first because of the keywords (discover, apply, federal discretionary funding) which might be what people are searching.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I'll go with the sentence A one-stop shop for all federal discretionary funding to make it easy for you to discover, understand, and apply for opportunities. and consider that as decided.

Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I appreciate testing the re-rendering in the test.

@SammySteiner SammySteiner merged commit ab6211e into main Aug 25, 2023
@SammySteiner SammySteiner deleted the sammysteiner/issue-397-title-description branch August 25, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Improve front-end SEO to comply with google best practices
4 participants