[ Issue 362 ] Ways to Get Involved Content #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammySteiner
changed the title
andycochran
approved these changes
Aug 22, 2023
| <a href="https://github.com/HHS/grants-equity/blob/main/documentation/milestones/milestone_short_descriptions.md" /> | ||
| ), | ||
| github: <a href="https://github.com/HHS/grants-equity" />, | ||
| email: <a href="mailto: [email protected]" />, |
There was a problem hiding this comment.
@sumiat, did you get an answer on which email we should be using here?
(Even so, we can update this in a subsequent PR.)
Comment on lines
5
to
9
| describe("Hero", () => { | ||
| it("Renders without errors", () => { | ||
| render(<WtGIContent />); | ||
| const hero = screen.getByTestId("wtgi-content"); | ||
| expect(hero).toBeInTheDocument(); |
There was a problem hiding this comment.
Is "hero" a copy/paste holdover?
There was a problem hiding this comment.
Yes, yes it was. Thanks for catching!
acouch
approved these changes
Aug 22, 2023
daphnegold
reviewed
Aug 22, 2023
|
|
||
| import WtGIContent from "src/components/WtGIContent"; | ||
|
|
||
| describe("Hero", () => { |
There was a problem hiding this comment.
This test still says "Hero"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #362
Time to review: 10 min
Changes proposed
Context for reviewers
Additional information
desktop width:
mobile width:
Storybook
Test Coverage