[External] Increase test coverage for dateUtil module in frontend. #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebra06
requested review from
acouch,
andycochran,
btabaska and
doug-s-nava
as code owners
doug-s-nava
approved these changes
Jan 7, 2025
|
Thank you for the code review @doug-s-nava. I am happy to have contributed to this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is currently a use case in the
dateUtilmodule that is preventing full unit test coverage. This pull requests covers that use case to get this module to 100% coverage.The use case is when a date string is passed into
formatDateand does not have 3 parts delimited by a-. When this use case occurs, we expect to log a warning in the console and is tested by this pr.Time to review: 5m
Changes proposed
Context for reviewers
Additional information