[Issue #3162] Make s3 buckets an iterator, with generated sub-paths #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
changed the title
coilysiren
changed the title
coilysiren
changed the title
coilysiren
commented
Dec 17, 2024
Comment on lines
+55
to
+66
| [ | ||
| for name, value in var.s3_buckets : | ||
| { name : value.env_var, value : "s3://${aws_s3_bucket.s3_buckets[name].bucket_regional_domain_name}" } | ||
| ], | ||
| flatten([ | ||
| for name, s3_bucket in var.s3_buckets : [ | ||
| for paths in s3_bucket.paths : { | ||
| name = paths.env_var, | ||
| value = "s3://${aws_s3_bucket.s3_buckets[name].bucket_regional_domain_name}${paths.path}" | ||
| } | ||
| ] | ||
| ]) |
doug-s-nava
pushed a commit
that referenced
this pull request
Dec 30, 2024
…3251) In service of #3163 Dynamically create S3 buckets with dynamically created paths. This was... complex 😅 <img width="883" alt="image" src="https://github.com/user-attachments/assets/56034045-f8b4-4396-b9ba-70a21784a624" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In service of #3163
Time to review: 10 mins
Changes proposed
Dynamically create S3 buckets with dynamically created paths. This was... complex 😅
Testing