[Issue #3043] Next login flow client #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
changed the title
Base automatically changed from
next-login-flow-backend
to
feature/nextjs-auth
December 16, 2024 16:09
doug-s-nava
force-pushed
the
next-login-flow-client
branch
from
fb4a81a to
514640b
Compare
doug-s-nava
force-pushed
the
feature/nextjs-auth
branch
from
ca566bd to
eaf62a3
Compare
doug-s-nava
requested review from
coilysiren,
mdragon,
btabaska,
chouinar and
widal001
as code owners
coilysiren
reviewed
Dec 17, 2024
| } | ||
| ``` | ||
|
|
||
| > ⚠️ Make sure you store the secret in SSM Parameter Store before you try to add secrets to your application service, or else the service won't be able to start since the ECS Task Executor won't be able to fetch the configured secret. | ||
| > ⚠️ For secrets with `manage_method = "manual"`, make sure you store the secret in SSM Parameter Store _before_ you try to add configure your application service with the secrets, or else the service won't be able to start since the ECS Task Executor won't be able to fetch the configured secret. |
There was a problem hiding this comment.
I assume you pulled this from platform verbatim and therefore it LGTM
There was a problem hiding this comment.
yup, this is copypasta
doug-s-nava
force-pushed
the
next-login-flow-client
branch
from
2009862 to
12f3234
Compare
doug-s-nava
added a commit
that referenced
this pull request
Dec 30, 2024
* adds a context provider and hook to allow client components to access up to date logged in user information * adds a NextJS route to return user data decrypted from the session cookie passed up from the client * makes some temporary updates to the feature flags table in order for that page to act as a proof of concept for the functionality * moves some feature flags and loading spinner code to a more suitable location.
doug-s-nava
added a commit
that referenced
this pull request
Jan 2, 2025
* adds a context provider and hook to allow client components to access up to date logged in user information * adds a NextJS route to return user data decrypted from the session cookie passed up from the client * makes some temporary updates to the feature flags table in order for that page to act as a proof of concept for the functionality * moves some feature flags and loading spinner code to a more suitable location.
doug-s-nava
added a commit
that referenced
this pull request
Jan 7, 2025
* adds a context provider and hook to allow client components to access up to date logged in user information * adds a NextJS route to return user data decrypted from the session cookie passed up from the client * makes some temporary updates to the feature flags table in order for that page to act as a proof of concept for the functionality * moves some feature flags and loading spinner code to a more suitable location.
acouch
pushed a commit
that referenced
this pull request
Jan 13, 2025
* adds a context provider and hook to allow client components to access up to date logged in user information * adds a NextJS route to return user data decrypted from the session cookie passed up from the client * makes some temporary updates to the feature flags table in order for that page to act as a proof of concept for the functionality * moves some feature flags and loading spinner code to a more suitable location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3043
Time to review: 20 mins
Changes proposed
Adds a context provider and hook to allow client components to access up to date logged in user information.
A NextJS route was added to return user data decrypted from the session cookie passed up from the client.
Some updates were made to the feature flags table in order for that page to act as a proof of concept for the functionality. These changes should be reverted before the feature goes live, but in the meantime are useful for testing.
Some feature flags and loading spinner code was moved to a more suitable location.
Context for reviewers
Test steps
npm run devon this branch in a new private windowAdditional information
Follow up