Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE 187] Deployment Strategy #307

Merged
merged 11 commits into from
Jul 21, 2023
Merged

[ISSUE 187] Deployment Strategy #307

merged 11 commits into from
Jul 21, 2023

Conversation

daphnegold
Copy link
Contributor

Summary

Fixes #187

Time to review: 10 mins

Changes proposed

ADR discussing deployment strategies considered.

@daphnegold daphnegold added the docs: adr Architecture decision record ticket label Jul 20, 2023
widal001
widal001 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@widal001 widal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! I think this is a smart choice, and the ADR highlights the pros and cons of the other solutions well.

Look at all those decisionsssss 🐔🐔🐔!!! (hopefully this isn't too much of a deepcut 😅)

@widal001 widal001 mentioned this pull request Jul 21, 2023
Closed
1 task
SammySteiner
SammySteiner approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@SammySteiner SammySteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for writing this up.
I left a few comments/suggestions.

documentation/decisions/adr/00NN-deployment-service.md Outdated Show resolved Hide resolved
documentation/decisions/adr/00NN-deployment-service.md Outdated Show resolved Hide resolved
documentation/decisions/adr/00NN-deployment-service.md Outdated Show resolved Hide resolved
lucasmbrown-usds
lucasmbrown-usds approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@lucasmbrown-usds lucasmbrown-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any concerns!

documentation/decisions/adr/00NN-deployment-service.md Outdated

## Decision Outcome <!-- REQUIRED -->

Chosen option: **ECS with Fargate launch type**, because it offers the most consistent and easy to use deployment strategy to host both the front-end and API layers of the Grants.gov modernization. Current template infrastructure integrates with ECS and the Fargate launch type.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@daphnegold daphnegold merged commit 4bc4314 into main Jul 21, 2023
@daphnegold daphnegold deleted the daphnegold/issue-187-deployment-service branch July 21, 2023 21:38
@sumiat sumiat mentioned this pull request Aug 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammySteiner SammySteiner SammySteiner approved these changes

@lucasmbrown-usds lucasmbrown-usds lucasmbrown-usds approved these changes

@widal001 widal001 widal001 approved these changes

Assignees
No one assigned
Labels
docs: adr Architecture decision record ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADR]: Deployment Strategy
4 participants
@daphnegold @widal001 @lucasmbrown-usds @SammySteiner