Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 174] ADR and coverage threshold #297

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

SammySteiner
Copy link
Contributor

Summary

Fixes #174

Time to review: 15 minuts

Changes proposed

Added ADR to address testing and coverage library used for the backend
Updated backend config to enforce test coverage threshold of 80%

Context for reviewers

You can view the test coverage by running make test-coverage from the /api directory.

@SammySteiner SammySteiner marked this pull request as ready for review July 19, 2023 18:16
Copy link
Contributor

@daphnegold daphnegold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

documentation/decisions/adr/0013-backend-testing.md Outdated Show resolved Hide resolved
### Testing Coverage
**Coverage**, because it is integrated into the Nava Flask template application, well-maintained, and lightweight. Importantly, documentation is thorough and helpful information for troubleshooting can be easily accessed.

We added a code coverage threshold of %80 in `api/pyproject.toml`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Collaborator

@widal001 widal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Yay for pytest!!!

@SammySteiner SammySteiner merged commit 7c7b45b into main Jul 20, 2023
@SammySteiner SammySteiner deleted the sammysteiner/issue-174-backend-testing-coverage branch July 20, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADR]: Backend Testing Framework and Coverage
3 participants