-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #2470] Removes deprecated analytics code #2718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widal001
requested review from
coilysiren,
acouch,
mxk0,
andycochran and
mdragon
as code owners
November 4, 2024 18:35
github-actions
bot
added
documentation
Improvements or additions to documentation
python
analytics
ci/cd
labels
Nov 4, 2024
coilysiren
previously approved these changes
Nov 4, 2024
widal001
force-pushed
the
issue-2489-deliverable-percent-complete
branch
from
November 4, 2024 20:58
3bf4720
to
f83575d
Compare
Something wonky happened with the attempted rebase on #2710, I'll be fixing this shortly! |
widal001
force-pushed
the
issue-2470-remove-deprecated-analytics-code
branch
from
November 4, 2024 21:20
4666e47
to
67192c3
Compare
Successfully rebased on #2710, will rebase against |
Base automatically changed from
issue-2489-deliverable-percent-complete
to
main
November 4, 2024 22:49
Removes the old exports that have been replaced by
widal001
force-pushed
the
issue-2470-remove-deprecated-analytics-code
branch
from
November 4, 2024 22:54
67192c3
to
c9791fe
Compare
Rebase on |
Here are the posts from the test run after rebasing on |
DavidDudas-Intuitial
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes deprecated analytics code after replacing it with new GitHub export pattern and dataset.
Note:
This PR is stacked on #2710 and needs to either be merged into #2710 before that PR is merged or rebased on✅ Done.main
after that PR is merged.Fixes #2470
Time to review: 5 mins
Changes proposed
SprintBoard
andDeliverableTask
datasetspoetry run analytics export issue_data
poetry run analytics export project_data
analytics/integrations/github/main.py
for these old export patternsdocumentation/analytics/usage.md
anddocumentation/analytics/development.md
to remove references to the old patternsMakefile
Context for reviewers
/documentation/analytics/development.md
including the instructions to set Slack environment variables (use the #z_bot-analytics-ci-test channel)make sprint-reports-with-latest-data
Additional information
The results posted to slack should look like this: