Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2470] Removes deprecated analytics code #2718

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Nov 4, 2024

Summary

Removes deprecated analytics code after replacing it with new GitHub export pattern and dataset.

Note: This PR is stacked on #2710 and needs to either be merged into #2710 before that PR is merged or rebased on main after that PR is merged. ✅ Done.

Fixes #2470

Time to review: 5 mins

Changes proposed

What was added, updated, or removed in this PR.

  • Removes SprintBoard and DeliverableTask datasets
  • Removes CLI entry points for the old method of exporting issue and project data:
    • poetry run analytics export issue_data
    • poetry run analytics export project_data
  • Removes code in analytics/integrations/github/main.py for these old export patterns
  • Updates documentation/analytics/usage.md and documentation/analytics/development.md to remove references to the old patterns
  • Cleans up targets in Makefile

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

  1. Follow the installation instructions in /documentation/analytics/development.md including the instructions to set Slack environment variables (use the #z_bot-analytics-ci-test channel)
  2. Run make sprint-reports-with-latest-data
  3. Check the output in #z_bot-analytics-ci-test

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

The results posted to slack should look like this:

Screenshot 2024-11-04 at 1 35 17 PM Screenshot 2024-11-04 at 1 35 29 PM

@github-actions github-actions bot added documentation Improvements or additions to documentation python analytics ci/cd labels Nov 4, 2024
coilysiren
coilysiren previously approved these changes Nov 4, 2024
@widal001 widal001 force-pushed the issue-2489-deliverable-percent-complete branch from 3bf4720 to f83575d Compare November 4, 2024 20:58
@widal001
Copy link
Collaborator Author

widal001 commented Nov 4, 2024

Something wonky happened with the attempted rebase on #2710, I'll be fixing this shortly!

@widal001 widal001 force-pushed the issue-2470-remove-deprecated-analytics-code branch from 4666e47 to 67192c3 Compare November 4, 2024 21:20
@widal001
Copy link
Collaborator Author

widal001 commented Nov 4, 2024

Successfully rebased on #2710, will rebase against main after that PR is merged.

Base automatically changed from issue-2489-deliverable-percent-complete to main November 4, 2024 22:49
@widal001 widal001 dismissed coilysiren’s stale review November 4, 2024 22:49

The base branch was changed.

@widal001 widal001 force-pushed the issue-2470-remove-deprecated-analytics-code branch from 67192c3 to c9791fe Compare November 4, 2024 22:54
@widal001
Copy link
Collaborator Author

widal001 commented Nov 4, 2024

Rebase on main after merging #2710

@widal001
Copy link
Collaborator Author

widal001 commented Nov 4, 2024

Here are the posts from the test run after rebasing on main and here's the view from the command line:

Screenshot 2024-11-04 at 6 16 26 PM

@widal001 widal001 merged commit 7999631 into main Nov 5, 2024
7 checks passed
@widal001 widal001 deleted the issue-2470-remove-deprecated-analytics-code branch November 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics ci/cd documentation Improvements or additions to documentation python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old deliverable reports from /analytics codebase
3 participants