Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2528] Change job schedule ELT process to hourly #2641

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

chouinar
Copy link
Collaborator

Summary

Fixes #2528

Time to review: 3 mins

Changes proposed

Modified ELT process to run hourly

Removed the load job for the v0 data

Context for reviewers

I can't imagine there is much value in the v0 job now that v1 works. Probably will save us a bit as we won't be running a process near constantly that no one uses.

I changed the schedule expression to a cron so that the schedule is a bit more consistent. The rate(..) configuration seems to be based on when you turn it on, or last did a deploy. This will keep it from varying every time we deploy and instead make it so it's always at the top of the hour.

Additional information

https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-scheduled-rule-pattern.html

Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in concept, but we'll want to solve the terraform lint error 🙏🏽

@chouinar
Copy link
Collaborator Author

Approved in concept, but we'll want to solve the terraform lint error 🙏🏽

I don't know why I always forget terraform formatting. I run the format command like 3x for every API change I make

Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q for the sake of my own knowledge: the load transform job also copies Oracle data?

@chouinar
Copy link
Collaborator Author

Q for the sake of my own knowledge: the load transform job also copies Oracle data?

Load transform is the full ELT process made up of 3 "tasks"

  • Load data from Oracle via the FDW into our staging tables
  • Run the transformation logic between the staging and actual opportunity tables
  • Set current opportunities

The job I deleted is the old v0 copy job that loads into the "transfer" tables that we never expanded past just the singular opportunity table.

@chouinar chouinar merged commit 17321cf into main Oct 30, 2024
7 checks passed
@chouinar chouinar deleted the chouinar/2528-hourly-transform branch October 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust transform job to run hourly
3 participants