Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2471] Update SprintBurndown to use GitHubIssues dataset #2618

Merged
merged 10 commits into from
Oct 31, 2024

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Oct 29, 2024

Summary

Stacked PR that builds on #2539 to replace the SprintBoard dataset in SprintBurndown and SprintBurnup with the new GitHubIssues dataset.

Fixes #2471

Note: Once we merge in #2539 I'll rebase this branch on main and change the base for the PR to main Rebased ✅

Time to review: 10 mins

Changes proposed

What was added, updated, or removed in this PR.

  • Replaces the SprintBoard dataset with GitHubIssues in the SprintBurndown and SprintBurnup metrics
  • Reuses intermediate steps to calculate burnup/burndown across both SprintBurnup and SprintBurndown

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

  1. Follow the instructions to run this code natively (in order to view the chart)
  2. Export the data: make delivery-data-export POINTS_FIELD="Story Points"
  3. Run burndown: make sprint-burndown

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

You should see a chart that looks like this:

Screenshot 2024-10-29 at 9 33 41 AM

And it should output the following stats:

Screenshot 2024-10-29 at 9 35 03 AM

acouch
acouch previously approved these changes Oct 29, 2024
Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. For clarity, do plan to keep using this once everything is connected with Metabase? Do you plan on using both?

@widal001
Copy link
Collaborator Author

Code LGTM. For clarity, do plan to keep using this once everything is connected with Metabase? Do you plan on using both?

@acouch Great question! @DavidDudas-Intuitial and I were just talking through this yesterday.

I think the tentative plan is to run both in parallel for 2-3 sprints (maybe less) just for quality control then we'll likely deprecate Sprinty McBurndown reports once we can support as is / as was reporting in Metabase.

Base automatically changed from issue-2481-add-new-github-export to main October 29, 2024 16:48
@widal001 widal001 dismissed stale reviews from DavidDudas-Intuitial and acouch October 29, 2024 16:48

The base branch was changed.

@widal001 widal001 force-pushed the issue-2471-turn-on-sprint-burndown branch from 2c7b9d4 to a55cdd3 Compare October 30, 2024 13:00
@widal001
Copy link
Collaborator Author

@DavidDudas-Intuitial I rebased this PR on main so this should be ready for a final review!

@acouch Welcome your review too if you'd like to take another look.

@widal001 widal001 changed the title [Issue #2471] Turn on SprintBurndown [Issue #2471] Update SprintBurndown to use GitHubIssues dataset Oct 30, 2024
Copy link
Collaborator

@DavidDudas-Intuitial DavidDudas-Intuitial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice work removing the redundant code.

@widal001 widal001 merged commit 2be4951 into main Oct 31, 2024
7 checks passed
@widal001 widal001 deleted the issue-2471-turn-on-sprint-burndown branch October 31, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SprintBurndown and SprintBurnup to use GitHubIssues dataset
3 participants