Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unticketed] Esbuild failing scans #2502

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[Unticketed] Esbuild failing scans #2502

merged 1 commit into from
Oct 16, 2024

Conversation

mdragon
Copy link
Collaborator

@mdragon mdragon commented Oct 16, 2024

Attempt to manually zap esbuild since we don't need it and it's failing the security scans.

emilycnava
emilycnava approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@emilycnava emilycnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mdragon mdragon merged commit 53b45ec into main Oct 16, 2024
11 checks passed
@mdragon mdragon deleted the mdragon/esbuild-failing-security-scans branch October 16, 2024 19:55
@doug-s-nava doug-s-nava mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilycnava emilycnava emilycnava approved these changes

@coilysiren coilysiren coilysiren approved these changes

@andycochran andycochran Awaiting requested review from andycochran andycochran is a code owner

@acouch acouch Awaiting requested review from acouch acouch is a code owner

@doug-s-nava doug-s-nava Awaiting requested review from doug-s-nava doug-s-nava is a code owner

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdragon @coilysiren @emilycnava