[Issue #2123] Add Opportunity Attachment and Lookup Tables #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
reviewed
Oct 16, 2024
mikehgrantsgov
changed the title
Co-authored-by: Michael Chouinard <[email protected]>
Co-authored-by: Michael Chouinard <[email protected]>
github-actions
bot
requested review from
mxk0,
widal001 and
andycochran
as code owners
chouinar
reviewed
Oct 16, 2024
Comment on lines
401
to
403
| opportunity_id: Mapped[int] = mapped_column( | ||
| BigInteger, ForeignKey(Opportunity.opportunity_id), primary_key=True, index=True | ||
| ) |
There was a problem hiding this comment.
Missed this the first time, we don't need opportunity ID to be a part of the primary key here I don't think.
There was a problem hiding this comment.
Ah, makes sense. Made that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2123
Time to review: 10 mins
Changes proposed
Context for reviewers
See generated migration and screenshots of result after db upgrade.
Only the created_by, updated_by, and legacy_folder_id columns should be nullable.
Additional information
Screenshots of new tables after running
make db-upgrade