[Issue #2472] Terraform in ECS #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Oct 16, 2024
Comment on lines
+1
to
+3
| node_modules | ||
| **/.terraform/** | ||
| .git |
There was a problem hiding this comment.
The build was pulling in all the .terraform files, which made the build huge. Like 10 GB
coilysiren
commented
Oct 16, 2024
Comment on lines
+7
to
+9
| COPY --from=top-level-directory bin /app/bin | ||
| COPY --from=top-level-directory infra /app/infra | ||
| COPY --from=top-level-directory Makefile /app/Makefile |
There was a problem hiding this comment.
Fancy new docker features here, ability to pull from a context above your current folder
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,20 @@ | |||
| data "external" "account_ids_by_name" { | |||
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,7 @@ | |||
| module "dev_config" { | |||
There was a problem hiding this comment.
copy paste and snipped
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,7 @@ | |||
| module "staging_config" { | |||
There was a problem hiding this comment.
copy paste and snipped
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,7 @@ | |||
| module "prod_config" { | |||
There was a problem hiding this comment.
copy paste and snipped
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,31 @@ | |||
| output "app_name" { | |||
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,60 @@ | |||
| locals { | |||
There was a problem hiding this comment.
copy paste with slight modifications
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,22 @@ | |||
| variable "app_name" { | |||
There was a problem hiding this comment.
copy paste and snipped
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,11 @@ | |||
| output "service_config" { | |||
There was a problem hiding this comment.
copy paste and snipped
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,17 @@ | |||
| locals { | |||
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,59 @@ | |||
| data "aws_iam_role" "github_actions" { | |||
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,56 @@ | |||
| # Make the "image_tag" variable optional so that "terraform plan" | |||
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,107 @@ | |||
| # docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc | |||
There was a problem hiding this comment.
copy paste from the analytics module, which also is "triggered only" (eg. no web server)
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,24 @@ | |||
| output "service_endpoint" { | |||
coilysiren
commented
Oct 16, 2024
| @@ -0,0 +1,16 @@ | |||
| module "secrets" { | |||
coilysiren
commented
Oct 16, 2024
Comment on lines
+33
to
+37
| build: | ||
| docker buildx build \ | ||
| --build-context top-level-directory=../ \ | ||
| --tag $(notdir $(shell pwd)):latest \ | ||
| . |
mdragon
approved these changes
Oct 16, 2024
coilysiren
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Relates to #2472, undos #2480 ### Time to review: __0.1 mins__ ## Changes proposed Removes all the ecs-terraform stuff ## Context for reviewers I spent more time on this than my (self imposed) timebox, so I'm swapping to the VPN route instead. If nothing else, it was in fact fun to work on. What is engineering if not the PRs we made along the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributes to, but does not solve, #2472
Time to review: 10 mins
Changes proposed
Adds a new ECS service that contains:
I plan on using this ECS service to deploy terraform from inside of our VPC
Context for reviewers
95% of this PR is copy paste, which is just how it is.
The parts that are specific to this PR are:
.dockerignoreecs-terraform/Dockerfileecs-terraform/Makefile