Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 33] Static Site milestone doc #243

Merged
merged 18 commits into from
Aug 15, 2023
Merged

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Jul 14, 2023

Summary

Creates the milestone doc for Static Site for NOFO Content

Fixes #33

Time to review: 15 minutes

Changes proposed

What was added, updated, or removed in this PR.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

The document may be easier to review in a rendered format

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

TODO

The following tasks still need to be complete before this PR is ready for review

  • User stories
  • Technical description
  • Proposed metrics
  • Integrations
  • Planning

@widal001 widal001 marked this pull request as draft July 14, 2023 22:11
@widal001 widal001 added draft Not yet ready for review docs: deliverable Deliverable specification ticket labels Jul 14, 2023
@widal001 widal001 marked this pull request as ready for review July 24, 2023 13:42
@widal001 widal001 removed the draft Not yet ready for review label Jul 24, 2023
- Qualifies links to internal resources criterion
- Fixes translation of docs bullet
@widal001 widal001 changed the title [ISSUE 33] Static Site milestone doc [Issue 33] Static Site milestone doc Aug 1, 2023
Copy link
Collaborator

@lucasmbrown-usds lucasmbrown-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good! Nice work.

- Adds DoD for publishing content to beta.grants.gov
- Adds DoD for collecting web traffic data
- Adds DoD for creating tickets to collect remaining metrics data
- Adds outbound link data to metrics
- Adds target release for FY24 Q1 for translation process
Copy link
Collaborator

@lucasmbrown-usds lucasmbrown-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, small nits.

Copy link
Collaborator

@lucasmbrown-usds lucasmbrown-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd love to make sure @sumiat and the rest of the dev team weigh in before we finalize this, but I have no more remaining concerns.

Nice work on this, congrats on getting to this point!

- Links dependency GitHub issues
- Adjust language around security approval
@widal001
Copy link
Collaborator Author

Updated references to ATO in this commit

@widal001 widal001 merged commit b861776 into main Aug 15, 2023
@widal001 widal001 deleted the issue-33-static-site-milestone-doc branch August 15, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs: deliverable Deliverable specification ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone Doc: Static Site with NOFO Content
4 participants