improve header loading process #2427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
reviewed
Oct 10, 2024
| const navLinksFromFlags = featureFlaggedNavLinkConfigs.reduce( | ||
| (acc, link) => { | ||
| const { flag = "" } = link; | ||
| console.log("####", featureFlags[flag]); |
There was a problem hiding this comment.
Suggested change
| console.log("####", featureFlags[flag]); |
Looks like this got left in here.
|
Looks good so far. I still see flickering in the navigation, even if the feature flag code is removed. I would think that Next could be more efficient about not needing to re-render navigation. Not going to look further into it myself for the time being. |
|
Pushing pause on this for now, may need to refactor the useFeatureFlags hook to get this working properly. |
mdragon
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes (unticketed)
Time to review: 15 mins
Changes proposed
updates to allow header nav items to remain consistent between page navigations.
Context for reviewers
because the list of nav items was being instantiated as empty on first render, when loading the layout on navigation, there would be a flicker of the nav, waiting for the items to be created on the second render. With this change, the nav will be rendered by default without any feature flagged items, and feature flagged items will appear on second render. There are implementations that could prevent flickering, but we'd have to implement feature flags or translation a little differently, I think.
Test steps
Additional information