Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS for api/, analytics/, etc #1975

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

coilysiren
Copy link
Collaborator

@coilysiren coilysiren commented May 9, 2024

Summary

Fixes #1961

Time to review: 1 mins

Explaination

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Advice for Reviewers

Confirm that these are the folders you want to get notified on!

@coilysiren coilysiren changed the title Update CODEOWNERS for /api/ and /analytics/ Update CODEOWNERS for api/, analytics/, etc May 9, 2024
@coilysiren coilysiren marked this pull request as ready for review May 9, 2024 17:27
Comment on lines +10 to +11
/bin/ @aplybeah @coilysiren
/.github/ @aplybeah @coilysiren
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering /bin/ and /.github/ to both be "infra"

Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coilysiren coilysiren merged commit 1840df0 into main May 9, 2024
1 check passed
@coilysiren coilysiren deleted the coilysiren-patch-2 branch May 9, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update CODEOWNERS to More Strategically Suggest Reviewers
2 participants