[Issue #1940] Fix factories to initialize sequence based on DB values #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
previously approved these changes
May 7, 2024
rylew1
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1940
Time to review: 2 mins
Changes proposed
Adjusts our factories to handle loading the values from the DB
Removes the now-duplicate code from the db-seed-local
Context for reviewers
There's currently a bug with the db-seed-local script due to how the factories setup the primary keys. If you rerun the script, it doesn't know where to start for the opportunity assistance listing table, and starts again at
1. This fixes that by making it start from the correct DB value.