-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #1823]: Fix prod FE error #1824
Conversation
console.log("Throwing error: ", message, status_code, searchInputs); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this left in by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I want it to show in server logs. But there's still some problems with this PR so I need to commit some different changes @andycochran
frontend/src/app/search/error.tsx
Outdated
}; | ||
} | ||
|
||
parsedErrorData = JSON.parse(error.message) as ParsedError; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't set the var to falsey?
I had thought we might be able to just pass the error status code and type to the client error boundary component ( This PR unblocks analytics a bit but there's still a lingering question:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again since it looks like Andy originally approved earlier
Summary
Fixes #1823
Time to review: 5 min
Changes proposed
Error we can simulate locally (same thing on prod):