Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1781] terraform debugging #1782

Merged
merged 14 commits into from
Apr 19, 2024
Merged

[Issue #1781] terraform debugging #1782

merged 14 commits into from
Apr 19, 2024

Conversation

coilysiren
Copy link
Collaborator

@coilysiren coilysiren commented Apr 18, 2024

Summary

Fixes #1781

Time to review: 2 mins

Changes proposed

  • removes -refresh-only from terraform apply
  • adds miscellaneous logging

Context for reviewers

Without these changes, are terraform deploys in CI are broken.

@github-actions github-actions bot added the ci/cd label Apr 18, 2024
@coilysiren coilysiren changed the title TF debugging [Issue #1781] terraform debugging Apr 18, 2024
@rylew1
Copy link
Contributor

rylew1 commented Apr 19, 2024

Are we planning to remove some of the set trace and logging if this works?

@coilysiren
Copy link
Collaborator Author

Are we planning to remove some of the set trace and logging if this works?

I would like to keep those changes

rylew1
rylew1 previously approved these changes Apr 19, 2024
@coilysiren coilysiren marked this pull request as ready for review April 19, 2024 01:09
@rylew1
Copy link
Contributor

rylew1 commented Apr 19, 2024

Thanks for saving the day once again!

@coilysiren coilysiren merged commit 18bf809 into main Apr 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: All terraform deploys are broken as of April 18th
2 participants