[Issue #1659] Create general purpose s3 bucket #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this looks good, then I guess I can also update the architecture diagram. |
|
It's not as if the architecture diagram currently lists every single s3 bucket though... |
jamesbursa
previously approved these changes
Apr 17, 2024
aplybeah
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1659
Time to review: 4 mins
Changes proposed
Adds a "General Purpose" s3 bucket to all of our services. The s3 bucket exposes its location via the
S3_BUCKET_ARNenvironment variable. I assume this is going to be a long lived general purpose s3 bucket for... random stuff. Whatever you might want an S3 bucket for. It's also specifically for populating seed data, eg. #1659Context for reviewers
The S3 bucket itself is a near exact copy of the s3 bucket that we use for access logs.
Additional information
Note that the s3 bucket arn format is like so:
arn:aws:s3:::api-dev-general-purpose20240416221336163000000001. You probably want to.split(":")[-1]it to get just the name.