Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1760] Add translation fix #1760

Merged
merged 9 commits into from
Apr 17, 2024
Merged

[Issue #1760] Add translation fix #1760

merged 9 commits into from
Apr 17, 2024

Conversation

acouch
Copy link
Collaborator

@acouch acouch commented Apr 16, 2024

Summary

Fixes #1754 #1706

Time to review: 10 mins

Changes proposed

Temp fix to partially using app router. This is a temp fix for UI testing and will be corrected in #1657

Context for reviewers

All strings should look the same and be fixed on the search page.

Additional information

N/A

@acouch acouch changed the title Add translation fix [Issue #1760] Add translation fix Apr 17, 2024
@acouch acouch marked this pull request as ready for review April 17, 2024 15:44
andycochran
andycochran previously approved these changes Apr 17, 2024
Copy link
Collaborator

@andycochran andycochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (w/ nits)

frontend/src/components/BetaAlert.tsx Show resolved Hide resolved
frontend/src/components/Header.tsx Outdated Show resolved Hide resolved
frontend/src/components/Layout.tsx Show resolved Hide resolved
andycochran
andycochran previously approved these changes Apr 17, 2024
@acouch acouch requested review from andycochran and removed request for SammySteiner April 17, 2024 21:47
@acouch acouch merged commit 1bf5f91 into main Apr 17, 2024
9 checks passed
@acouch acouch deleted the acouch/issue-1754-string-fix branch April 17, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix Strings and Add Beta Banner to Search Page
3 participants