[Issue #1625] Deploy to staging and prod, fix path #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Apr 8, 2024
Comment on lines
+53
to
+54
| "Name" : "OUTPUT_DIR", | ||
| "Value" : "/tmp/", |
There was a problem hiding this comment.
Only /tmp is writable in ECS, but the previous code was hardcoding data as an output directory.
The error message that code produced, was:
OSError: [Errno 30] Read-only file system: 'data'
So this changes the code from writing to data to writing to /tmp
coilysiren
changed the title
coilysiren
requested review from
aplybeah,
acouch,
chouinar and
SammySteiner
as code owners
aplybeah
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1625
Time to review: 2 mins
Changes proposed
./dataTesting
staging
Staging step function running successfully:
output is here: https://betagrantsgov.slack.com/archives/C06L7JGT9M0/p1712613628944219
prod
Prod step function running successfully:
output is here: https://betagrantsgov.slack.com/archives/C064Y8VNW14/p1712613702615029