Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some agencies from left-hand search navigation that are confusing users #3237

Closed
1 task done
lucasmbrown-usds opened this issue Dec 16, 2024 · 0 comments · Fixed by #3238
Closed
1 task done
Assignees

Comments

@lucasmbrown-usds
Copy link
Collaborator

lucasmbrown-usds commented Dec 16, 2024

Summary

Someone wrote in saying they searched for ARPA-H cancer grants and didn't see any.

But that's because they used the "top level" ARPA-H that's been deprecated: https://simpler.grants.gov/search?query=cancer&agency=ARPAH

Whereas the actual grants they're looking for are nested under HHS / ARPA-H now: https://simpler.grants.gov/search?query=cancer&agency=HHS-ARPAH

We want to prioritize fixing this to return accurate data and not mislead our search users.

Here are some example agencies to quickly remove, (based on ID) as listed here: https://github.com/HHS/simpler-grants-gov/blob/main/frontend/src/components/search/SearchFilterAccordion/SearchFilterOptions.ts#L213

These are all top-level agencies:

  1. CNCS
  2. WWC
  3. USEAC
  4. ARPAH (note: do NOT remove "HHS-ARPAH" which is nested under HHS)
  5. ECP
  6. FMCS
  7. GDIT and all sub, nested agencies (unless this is already fixed by [Issue #3204] Remove opportunities connected to test agencies from search results #3234)
  8. IVV (unless this is already fixed by [Issue #3204] Remove opportunities connected to test agencies from search results #3234)
  9. MCC

Reproducibility

I tried multiple times and saw the bug every time

How to reproduce the bug

No response

Browser

Chrome

Code of Conduct

  • I agree to follow this project's Code of Conduct
mdragon added a commit that referenced this issue Dec 18, 2024
## Summary
Fixes #3237

### Time to review: __2 mins__

## Changes proposed
Remove some Agencies that shouldn't appear in the Search UI anyway.
doug-s-nava pushed a commit that referenced this issue Dec 30, 2024
## Summary
Fixes #3237

### Time to review: __2 mins__

## Changes proposed
Remove some Agencies that shouldn't appear in the Search UI anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants