Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup v0 and v0.1 opportunity endpoints #2553

Closed
2 tasks
chouinar opened this issue Oct 23, 2024 · 0 comments · Fixed by #3409, #3410 or #3411
Closed
2 tasks

Cleanup v0 and v0.1 opportunity endpoints #2553

chouinar opened this issue Oct 23, 2024 · 0 comments · Fixed by #3409, #3410 or #3411
Assignees

Comments

@chouinar
Copy link
Collaborator

chouinar commented Oct 23, 2024

Summary

DO NOT DO THIS UNTIL WE HAVE CONFIRMED WITH HHS AND STAKEHOLDERS

Once we've finished launching v1 opportunities backed by a search index, the older opportunity endpoints can be removed. They have no direct users, so there is no issue deleting them. This will remove a lot of duplicate code, and help simplify our code base quite a bit.

Things to delete:

This may be something we need to do in multiple PRs, especially regarding the DB tables to avoid anything breaking.

Acceptance criteria

  • Verify there is no traffic to the old endpoints and notify consumers if there is.
  • Code cleaned up
@chouinar chouinar moved this from Icebox to Todo in Simpler.Grants.gov Product Backlog Oct 23, 2024
@mikehgrantsgov mikehgrantsgov self-assigned this Jan 6, 2025
@mikehgrantsgov mikehgrantsgov moved this from Todo to In Progress in Simpler.Grants.gov Product Backlog Jan 6, 2025
mikehgrantsgov added a commit that referenced this issue Jan 6, 2025
## Summary
Fixes #2553 

### Time to review: 10 mins

## Changes proposed
Clean up v0 endpoints by removing `opportunities_v0`

## Context for reviewers
This is PR 1 of 3. Subsequent PRs will remove v0.1 and backend tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Simpler.Grants.gov Product Backlog Jan 6, 2025
mikehgrantsgov added a commit that referenced this issue Jan 7, 2025
## Summary
Fixes #2553 

### Time to review: 10 mins

## Changes proposed
Clean up v0.1 endpoints by removing `opportunities_v0.1`

## Context for reviewers
This is PR 2 of 3. Last PR will remove backend tasks
mikehgrantsgov added a commit that referenced this issue Jan 9, 2025
…[3/3] (#3411)

## Summary
Fixes #2553

### Time to review: 10 mins

## Changes proposed

Removes
https://github.com/HHS/simpler-grants-gov/blob/main/api/src/db/models/transfer/topportunity_models.py
+ generate migrations to remove this table
Removes
https://github.com/HHS/simpler-grants-gov/blob/main/api/src/data_migration/copy_oracle_data.py
- the script that loads data into the transfer table (Note there will be
some infra we want to remove to no longer schedule this job as well)
Transfer table removed
DB migration generated

## Context for reviewers
Final PR to clean up v0 and v0.1 opportunity endpoints, along with
supporting backend tasks.
Note, when PR #3409 is merged then the build errors will go away from
this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment