Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Make pagination unbounded #1925

Closed
rylew1 opened this issue May 6, 2024 · 1 comment · Fixed by #1939
Closed

[Task]: Make pagination unbounded #1925

rylew1 opened this issue May 6, 2024 · 1 comment · Fixed by #1939
Assignees
@rylew1
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@rylew1
Copy link
Contributor

rylew1 commented May 6, 2024

Summary

No end page
image

Acceptance criteria

  • Pagination component is unbounded and has no end page
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label May 6, 2024
@rylew1 rylew1 added this to the Search UI - Enhancements and fast follow milestone May 6, 2024
@rylew1
Copy link
Contributor Author

rylew1 commented May 7, 2024

@andycochran the way we achieve this is to just remove the totalPages prop pasesd into the uswds Pagination component. Do we have any need to keep that property around - or can it be removed from the whole codebase?

cc @chouinar - this property may not be needed even from the API anymore

@rylew1 rylew1 mentioned this issue May 7, 2024
Merged
@rylew1 rylew1 self-assigned this May 7, 2024
@rylew1 rylew1 moved this from Icebox to In Progress in Simpler.Grants.gov Product Backlog May 7, 2024
@rylew1 rylew1 moved this from In Progress to In Review in Simpler.Grants.gov Product Backlog May 7, 2024
rylew1 added a commit that referenced this issue May 7, 2024
@rylew1
[Issue #1925]: Make SearchPagination unbounded (#1939)
15d9a0d 
## Summary
Fixes #1925 

## Changes proposed
- remove `totalPages` from being passed into `SearchPagination` to make Pagination unbounded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #1925]: Make SearchPagination unbounded HHS/simpler-grants-gov
1 participant
@rylew1