Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: E2E tests for search page #1757

Closed
rylew1 opened this issue Apr 16, 2024 · 1 comment · Fixed by #1974 or navapbc/simpler-grants-gov#1
Closed

[Task]: E2E tests for search page #1757

rylew1 opened this issue Apr 16, 2024 · 1 comment · Fixed by #1974 or navapbc/simpler-grants-gov#1
Assignees
@rylew1
Labels
project: grants.gov Grants.gov Modernization tickets refinement

Comments

@rylew1
Copy link
Contributor

rylew1 commented Apr 16, 2024

Summary

Issue #1393 was started to create unit tests for the server components - but it has proven difficult .

The next docs recommend using e2e tests for server components https://nextjs.org/docs/app/building-your-application/testing#async-server-components

Acceptance criteria

  • E2e tests setup for search page
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label Apr 16, 2024
@rylew1 rylew1 added this to the Search UI - Enhancements and fast follow milestone Apr 16, 2024
@rylew1
Copy link
Contributor Author

rylew1 commented Apr 16, 2024

Fyi @acouch

@rylew1 rylew1 mentioned this issue Apr 26, 2024
Closed
@sumiat sumiat moved this from Icebox to Sprint Ready in Simpler.Grants.gov Product Backlog Apr 30, 2024
@rylew1 rylew1 self-assigned this May 7, 2024
@rylew1 rylew1 moved this from Sprint Ready to Blocked in Simpler.Grants.gov Product Backlog May 7, 2024
@acouch acouch moved this from Blocked to Icebox in Simpler.Grants.gov Product Backlog May 8, 2024
@rylew1 rylew1 moved this from Icebox to Sprint Ready in Simpler.Grants.gov Product Backlog May 8, 2024
@margaretspring margaretspring moved this from Sprint Ready to In Progress in Simpler.Grants.gov Product Backlog May 8, 2024
@rylew1 rylew1 mentioned this issue May 9, 2024
Merged
@rylew1 rylew1 moved this from In Progress to Blocked in Simpler.Grants.gov Product Backlog May 10, 2024
@rylew1 rylew1 moved this from Blocked to In Progress in Simpler.Grants.gov Product Backlog May 14, 2024
@rylew1 rylew1 mentioned this issue May 14, 2024
Merged
@rylew1 rylew1 closed this as completed in 85f3e0a May 14, 2024
rylew1 added a commit to navapbc/simpler-grants-gov that referenced this issue May 14, 2024
@rylew1
[Issue HHS#1757]: setup e2e tests for search (#1)
6bfd75e 
## Summary
Fixes HHS#1757 

## Changes proposed
- Add e2e tests for search page
- Add e2e test (with FE and API) to its own CI job
(`ci-frontend-ci.yml`)
    - invokes shell script to wait until API is loaded
This was referenced May 16, 2024
Closed
Closed
@acouch acouch mentioned this issue Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
project: grants.gov Grants.gov Modernization tickets refinement
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
2 participants
@rylew1 @sumiat