-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Add transformations for the assistance listing tables #1746
Labels
project: grants.gov
Grants.gov Modernization tickets
Comments
github-project-automation
bot
moved this to Icebox
in Simpler.Grants.gov Product Backlog
Apr 16, 2024
chouinar
moved this from Sprint Ready
to In Progress
in Simpler.Grants.gov Product Backlog
Apr 29, 2024
chouinar
added a commit
that referenced
this issue
Apr 29, 2024
chouinar
added a commit
that referenced
this issue
May 3, 2024
This is a follow-up to #1794 - which it builds upon. ## Summary Fixes #1746 ### Time to review: __10 mins__ ## Changes proposed Adds transformation logic for the assistance listing (formerly CFDA) tables. ## Context for reviewers The transformations are pretty uneventful, the only complexity is that the legacy Oracle database doesn't have a foreign key between the `TopportunityCfda` table and the `Topportunity` table and there are ~2300 orphaned cfda records that we wouldn't be able to import, so we additionally need to validate that the opportunity exists when we try to transform the data, and if not, we just mark it as "transformed" and do nothing with it. There is some basic work on relationships between the staging tables + more factories for setting up the data which will be ongoing / @jamesbursa is also looking into. --------- Co-authored-by: nava-platform-bot <[email protected]>
github-project-automation
bot
moved this from In Review
to Done
in Simpler.Grants.gov Product Backlog
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Handles transforms for the assistance listing table
https://app.gitbook.com/o/cFcvhi6d0nlLyH2VzVgn/s/v1V0jIH7mb7Yb3jlNrgk/engineering/learnings/opportunity-endpoint-data-model#opportunity-assistance-listing
Acceptance criteria
No response
The text was updated successfully, but these errors were encountered: