Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Add Foreign Tables in setup_foreign_tables.py for the new tables #1697

Closed
1 task
acouch opened this issue Apr 12, 2024 · 0 comments · Fixed by #1769
Closed
1 task

[Task]: Add Foreign Tables in setup_foreign_tables.py for the new tables #1697

acouch opened this issue Apr 12, 2024 · 0 comments · Fixed by #1769
Assignees
@jamesbursa
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@acouch
Copy link
Collaborator

acouch commented Apr 12, 2024 •
edited
Loading

Summary

Expand setup_foreign_tables.py to include new search API tables.

Acceptance criteria

  • setup_foreign_tables.py incldues the new tables
@acouch acouch added the project: grants.gov Grants.gov Modernization tickets label Apr 12, 2024
@acouch acouch added this to the Search API - ELT Implementation milestone Apr 12, 2024
@acouch acouch moved this from Icebox to Sprint Ready in Simpler.Grants.gov Product Backlog Apr 12, 2024
@acouch acouch mentioned this issue Apr 15, 2024
Closed
1 task
@jamesbursa jamesbursa self-assigned this Apr 17, 2024
@jamesbursa jamesbursa moved this from Sprint Ready to In Progress in Simpler.Grants.gov Product Backlog Apr 17, 2024
jamesbursa added a commit that referenced this issue Apr 17, 2024
@jamesbursa
[Issue #1697] add more foreign table models and update setup_foreign_…
4a23597 
…tables.py
@jamesbursa jamesbursa mentioned this issue Apr 17, 2024
Merged
@acouch acouch mentioned this issue Apr 23, 2024
Closed
4 tasks
@margaretspring margaretspring moved this from In Progress to In Review in Simpler.Grants.gov Product Backlog Apr 24, 2024
jamesbursa added a commit that referenced this issue Apr 25, 2024
@jamesbursa
[Issue #1697] add more foreign table models and update setup_foreign_…
043ed8c 
…tables.py (#1769)

## Summary
Fixes #1697

## Changes proposed

- Add `src.db.foreign` module defining the foreign tables as SQLAlchemy
models.
- Place the tables in a separate database schema.
- Update `setup_foreign_tables.py` to use the new models instead of its
own definition.
- Update `copy_oracle_data.py` to use the new database schema.
- Update unit tests.

## Context for reviewers

Currently we only have one table from the source database available as a
foreign table. This change adds the remaining tables, and also moves
them into a separate schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesbursa jamesbursa

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
2 participants
@acouch @jamesbursa