Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: SearchFetcherProps should be renamed (drop the props) #1680

Closed
rylew1 opened this issue Apr 12, 2024 · 1 comment · Fixed by #1973
Closed

[Task]: SearchFetcherProps should be renamed (drop the props) #1680

rylew1 opened this issue Apr 12, 2024 · 1 comment · Fixed by #1973
Assignees
@rylew1
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@rylew1
Copy link
Contributor

rylew1 commented Apr 12, 2024

Summary

SearchFetcherProps is a type used throughout the frontend to reference query param state. Typically using props in a name is associated with an interface - so this should be renamed .

Could be SearchFetcherData or similar

Acceptance criteria

SearchFetcherProps is renamed
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label Apr 12, 2024
@acouch
Copy link
Collaborator

acouch commented Apr 15, 2024

@rylew1 can we move this to: https://github.com/HHS/simpler-grants-gov/milestone/155 since it is something we want to do before closing this line of work but is not blocking users from testing the search page?

@acouch acouch modified the milestones: Search UI - Create initial search page, Search UI - Enhancements and fast follow Apr 15, 2024
@rylew1 rylew1 self-assigned this May 9, 2024
@rylew1 rylew1 moved this from Icebox to In Progress in Simpler.Grants.gov Product Backlog May 9, 2024
@rylew1 rylew1 mentioned this issue May 9, 2024
Merged
@rylew1 rylew1 moved this from In Progress to In Review in Simpler.Grants.gov Product Backlog May 9, 2024
rylew1 added a commit that referenced this issue May 9, 2024
@rylew1
[Issue #1680]: rename SearchFetcherProps to QueryParamData (#1973)
8c134a5 
## Summary
Fixes #1680 

## Changes proposed
- rename `SearchFetcherProps` to `QueryParamData` to more accurately
represent this interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #1680]: rename SearchFetcherProps to QueryParamData HHS/simpler-grants-gov
2 participants
@acouch @rylew1