Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Add env vars for the Search API #1521

Closed
1 task
acouch opened this issue Mar 22, 2024 · 3 comments · Fixed by #1750, #1755 or #1759
Closed
1 task

[Task]: Add env vars for the Search API #1521

acouch opened this issue Mar 22, 2024 · 3 comments · Fixed by #1750, #1755 or #1759
Assignees
@rylew1
Labels
project: grants.gov Grants.gov Modernization tickets
Milestone
Search UI - Creat...

Comments

@acouch
Copy link
Collaborator

acouch commented Mar 22, 2024 •
edited by sumiat
Loading

Summary

This task is to add the API_URL and API_AUTH_TOKEN to the dev and stage and prod ECS task env vars so that the dev and stage search pages can connect to the dev and stage and prod APIs.

Without the transformation work, there will be no data to read the data.

Acceptance criteria

  • search page can connect to the search api
@acouch acouch added the project: grants.gov Grants.gov Modernization tickets label Mar 22, 2024
@rylew1
Copy link
Contributor

rylew1 commented Mar 22, 2024 •
edited
Loading

You might add a dependency or relationship to a ticket for dev to be seeded with data? If the schema is actually setup in dev with blank tables, I think it would work and show 0 results on the search page.

I'm not sure if stage or prod have a dependency for some kind of release to bump them to API v0.1 ?

@rylew1 rylew1 mentioned this issue Mar 22, 2024
Merged
@coilysiren
Copy link
Collaborator

Use the new pattern added in #1516, #1526 when doing this

@rylew1 rylew1 mentioned this issue Mar 22, 2024
Merged
@sumiat sumiat removed the refinement label Apr 1, 2024
@sumiat sumiat moved this from Icebox to Sprint Ready in Simpler.Grants.gov Product Backlog Apr 1, 2024
@rylew1 rylew1 self-assigned this Apr 9, 2024
@coilysiren coilysiren self-assigned this Apr 15, 2024
@coilysiren
Copy link
Collaborator

Ryan DMed me to say that he wanted to work on this

@coilysiren coilysiren assigned rylew1 and unassigned coilysiren Apr 16, 2024
@rylew1 rylew1 moved this from Sprint Ready to In Progress in Simpler.Grants.gov Product Backlog Apr 16, 2024
@rylew1 rylew1 mentioned this issue Apr 16, 2024
Merged
rylew1 added a commit that referenced this issue Apr 16, 2024
@rylew1
[Issue #1521]: Add env vars to connect frontend search to API (#1750)
587e02b 
## Summary
Fixes #1521 

## Changes proposed
- Add env vars to terraform
- Add `/frontend/<env>/api-url` and `/frontend/<env>/api-auth_toekn` for
dev/staging/prod to Parameter Store
@rylew1 rylew1 mentioned this issue Apr 16, 2024
Merged
rylew1 added a commit that referenced this issue Apr 16, 2024
@rylew1
[Issue #1521]: Remove dockerfile env var args (#1755)
5325e7c 
## Summary
Fixes #1521 

## Changes proposed
- remove frontend `Dockerfile` API env vars
@coilysiren coilysiren mentioned this issue Apr 16, 2024
Merged
coilysiren added a commit that referenced this issue Apr 16, 2024
@coilysiren
[Issue #1521]: fix API_AUTH_TOKEN clash between backend and frontend (#…
c7be8c8 
…1759)

## Summary

Fixes #1521

### Time to review: __2 mins__

## Context

Both `infra/api` and `infra/frontend` were defining a variable called
`API_AUTH_TOKEN`. The way they were defined made them clash, leading to
the following error message:

> Error: creating ECS Task Definition (frontend-dev): ClientException:
The secret name must be unique and not shared with any new or existing
environment variables set on the container, such as 'API_AUTH_TOKEN'

## Changes proposed

Refactors the terraform configuration so the `API_AUTH_TOKEN` definition
is no longer clashing between the frontend and backend

## Testing

I have already deployed both the API and the frontend to dev to test
that this is working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylew1 rylew1

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
Search UI - Create initial search page
4 participants
@acouch @coilysiren @rylew1 @sumiat