Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Goal source bugfix, update python, don't roll up goals, create hidden monitoring goal template, store uncovered code report as build artifact #2478

Merged
merged 151 commits into from
Nov 14, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Nov 13, 2024

Description of change

  • Fix validation for goal source
  • Add Regional Program Director user role

[TTAHUB-3502] Remove goal roll up.
[TTAHUB-3513] Create goal template for CRON monitoring goal.

This PR also includes an update to our version of python, increased test coverage, and a change to our CI to store a report on code uncovered by unit tests.

How to test

  • Confirm that you cannot submit a goal via the RTR or submit an AR without a source
  • Regional Program Director appears as a possible user role in the admin screen but does not appear in the filters

[TTAHUB-3502] Goals on the RTR and merge should be grouped by grant.
[TTAHUB-3513] Nothing to test BE only.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

thewatermethod and others added 23 commits November 13, 2024 10:26
[TTAHUB-3502] Unwind goals on the RTR and Similarity API
…t-with-regional-program-director

[TTAHUB-3581] Add regional program director user role
…-creation-method

[TTAHUB-3513] Create 'System Created' enum for GoalTemplates
…istory

[TTAHUB-3451]format comlog comdate history
[TTAHUB-3628] Migration deployment issue
@thewatermethod thewatermethod marked this pull request as ready for review November 14, 2024 18:47
@kryswisnaskas
Copy link
Collaborator

Merging since this includes critical production fixes.

@kryswisnaskas kryswisnaskas merged commit 4b59d5f into production Nov 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants